Skip to content

Fixing issues #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flyingcircle merged 3 commits into from
Apr 19, 2021
Merged

Fixing issues #2964

flyingcircle merged 3 commits into from
Apr 19, 2021

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 13, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@5c2d6b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2964   +/-   ##
=======================================
  Coverage        ?   79.31%           
=======================================
  Files           ?       53           
  Lines           ?     1131           
  Branches        ?      449           
=======================================
  Hits            ?      897           
  Misses          ?      182           
  Partials        ?       52
Impacted Files Coverage Δ
src/buttons/Button.tsx 87.80% <ø> (ø)
src/buttons/FAB.tsx 50.00% <ø> (ø)
src/buttons/SpeedDial.tsx 55.00% <ø> (ø)
src/list/ListItemAccordion.tsx 5.55% <ø> (ø)
src/tab/tab.tsx 60.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d6b6...d499207. Read the comment docs.

@arpitBhalla arpitBhalla marked this pull request as draft April 13, 2021 17:27
@arpitBhalla arpitBhalla changed the title Fixing #2960 Fixing issues Apr 16, 2021
@arpitBhalla arpitBhalla marked this pull request as ready for review April 18, 2021 17:35
@flyingcircle flyingcircle merged commit 6713620 into react-native-elements:next Apr 19, 2021
@arpitBhalla arpitBhalla deleted the button branch April 19, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to theme Avatar.Accessory? Typescript errors when merging declarations to extend theme

2 participants

@arpitBhalla @flyingcircle