Codecov Report

Merging #2944 (c2315ec) into next (d78718c) will decrease coverage by 2.83%.
The diff coverage is 59.82%.

❗ Current head c2315ec differs from pull request most recent head 1d22ee3. Consider uploading reports for the commit 1d22ee3 to get more accurate results

@@            Coverage Diff             @@
##             next    #2944      +/-   ##
==========================================
- Coverage   88.20%   85.37%   -2.84%     
==========================================
  Files          50       57       +7     
  Lines        1009     1121     +112     
  Branches      399      441      +42     
==========================================
+ Hits          890      957      +67     
- Misses         76      105      +29     
- Partials       43       59      +16     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78718c...1d22ee3. Read the comment docs.

@flyingcircle, I have upgraded it.

Very nice! Yes, this is more like what I was thinking. I'm wondering though, it looks like you copied a good chunk of the code over. Why just use ListItem as is? Is there a compelling reason that We need DropdownItem and the associated components? Couldn't people just use ListItem?

I have a doubt, it is not called dropdown, It can be Expandable or Accordion

@flyingcircle yes, there is a reason, I was thinking as it would add more flexibility and rigidity. As further updated or modification to ListItem would not cause any bugs in Dropdown. Also other way it would be more flexible to be change or add anything to Dropdown in particular. Plus it matches the theme. Also using ListItem in Dropdown instead of Dropdown.Item will not cause dropdown to retract when onPress is defined in list.

@arpitBhalla Expandable is great suggestion.

@flyingcircle what's your opinion, should it need to be changed to Expandable or not.

Decided to go with #2953 as it fit in a bit more with existing code.