Skip to content

Removed ts-ignore and transformed to Functional Component #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flyingcircle merged 4 commits into from
Mar 12, 2021
Merged

Removed ts-ignore and transformed to Functional Component #2834

flyingcircle merged 4 commits into from
Mar 12, 2021

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 12, 2021 •
edited
Loading

What kind of change does this PR introduce?
bugfix: removed ts-ignore and changed to functional component

I changed

  • Button [ Functional and ts-ignore fixed ]
  • PricingCard [ ts-ignore fixed ]
  • Checkbox [ Functional and ts-ignore fixed ]
    Fixing Fix all @ts-ignore tags #2798

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

@arpitBhalla arpitBhalla changed the title Button removed ts-ignore and tansformed to Functional Button removed ts-ignore and transformed to Functional Component Mar 12, 2021
@arpitBhalla
Copy link
Member Author

arpitBhalla commented Mar 12, 2021

@flyingcircle Kindly review😃

@codecov
Copy link

codecov bot commented Mar 12, 2021 •
edited
Loading

Codecov Report

Merging #2834 (1fe8668) into next (5bc3ac3) will not change coverage.
The diff coverage is 92.06%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2834   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          47       47           
  Lines         952      952           
  Branches      370      370           
=======================================
  Hits          858      858           
  Misses         61       61           
  Partials       33       33
Impacted Files Coverage Δ
src/checkbox/CheckBox.tsx 88.00% <0.00%> (ø)
src/pricing/PricingCard.tsx 100.00% <ø> (ø)
src/buttons/Button.tsx 95.12% <94.11%> (ø)
src/buttons/ButtonGroup.tsx 97.82% <96.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc3ac3...69091b9. Read the comment docs.

@arpitBhalla arpitBhalla changed the title Button removed ts-ignore and transformed to Functional Component Removed ts-ignore and transformed to Functional Component Mar 12, 2021
@flyingcircle flyingcircle merged commit 2f50ef0 into react-native-elements:next Mar 12, 2021
@arpitBhalla
Copy link
Member Author

arpitBhalla commented Mar 12, 2021

@flyingcircle Thanku

This was referenced Mar 12, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpitBhalla @flyingcircle