Skip to content

feat(Header): Add background image #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iRoachie merged 8 commits into from
Dec 5, 2018
Merged

feat(Header): Add background image #1556

iRoachie merged 8 commits into from
Dec 5, 2018

Conversation

@MHase
Copy link
Contributor

@MHase MHase commented Nov 5, 2018

Issue: #1551
Added possibility to pass backgroundImage prop which is simply source prop like in Image component :) e.g. :

source={{ uri: 'http://google.com' }}

img_4187

@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

Merging #1556 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1556   +/-   ##
=======================================
  Coverage   76.23%   76.23%           
=======================================
  Files          32       32           
  Lines         606      606           
  Branches       78       78           
=======================================
  Hits          462      462           
  Misses        125      125           
  Partials       19       19
Impacted Files Coverage Δ
src/header/Header.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6035436...2edf601. Read the comment docs.

@iRoachie
Copy link
Collaborator

iRoachie commented Nov 6, 2018

Brooooo this PR is 🔥

iRoachie
iRoachie reviewed Nov 6, 2018
View reviewed changes
Copy link
Collaborator

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one thing we way want to add. The ImageBackground component has a imageStyle prop which is used to style the Image https://facebook.github.io/react-native/docs/imagebackground#imagestyle.

So the user can access this, we may want to add backgroundImageStyle prop.

OR we could say that it has all the props from the ImageBackground Component and we'd need to update the typescript definitions to say that.

iRoachie
iRoachie reviewed Nov 6, 2018
View reviewed changes
iRoachie
iRoachie approved these changes Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man this looks so amazing 💯

screen shot 2018-12-05 at 3 55 50 am

@iRoachie iRoachie merged commit 1957e0d into react-native-elements:next Dec 5, 2018
@iRoachie iRoachie mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iRoachie iRoachie iRoachie approved these changes

Assignees

No one assigned

Labels

✨ Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MHase @iRoachie