-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
Description
Button component renders a <ViewComponent/> and a <Text/> inside it. For a Button with disabled attribute, styles.disabled overrides buttonStyle in styles of ViewComponent but styles.disabledTitle does not override titleStyle in styles of Text.
Commit react-native-training/react-native-elements@5af9b15 has moved buttonStyle after styles.disabled but titleStyle is still before styles.disabledTitle:
This causes inconsistency in a usage like this:
<Button buttonStyle={{backgroundColor:'black', color:'white'}} disabled={true} />This component will have black background but gray text color which is neither user's style (color != white) nor default disabled style (backgroundColor != #D1D5D8)