fix: temporary fix for a regression in monorepos#852
Merged
Conversation
This was referenced Nov 15, 2019
Member
|
Since this is causing issues, I am wondering whether we shouldn't revert #824 entirely and just leave it as it was before? I believe the amount of regressions is larger than a small number of developers facing issues with a non-standard Gradle project setup (e.g. #804). We should probably think about it once again and ship a better fix in the next release. I can spend some time on these two this week. |
|
Any news on this one? Currently if I start a fresh project with This may cause some frustration to people who are just starting with the framework and have no idea where to look to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Regression introduced in #824. Still looking for a better fix, because otherwise we'll need to reopen #793 and #804.
cc @mbios
Test Plan: