Skip to content

Fix types for #753#755

Closed
controversial wants to merge 3 commits into
react-hook-form:fix/743from
controversial:fix/743
Closed

Fix types for #753#755
controversial wants to merge 3 commits into
react-hook-form:fix/743from
controversial:fix/743

Conversation

@controversial

@controversial controversial commented Mar 6, 2025

Copy link
Copy Markdown

cc @jorisre

To be merged into #753 in order to fix typescript issues

based on the comments I left in #753 (comment)

@controversial

controversial commented Mar 6, 2025

Copy link
Copy Markdown
Author

See also react-hook-form/react-hook-form#12664 which fixes more type failures in tests

@controversial

Copy link
Copy Markdown
Author

@jorisre Is there anything else I can do to help with your PRs?

@jorisre

jorisre commented Mar 12, 2025

Copy link
Copy Markdown
Member

@controversial appreciate the support! I implemented your suggested changes to the zod resolver and it's working great. Planning to apply the same logic to all the other relevant resolvers as well.

@controversial

Copy link
Copy Markdown
Author

Merged into #753 in 06f3b08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants