[Fix] DayPicker, DayPickerSingleDateController: Snap to new date if date is off screen#1481
Merged
ljharb merged 1 commit intoreact-dates:masterfrom Nov 30, 2021
Merged
[Fix] DayPicker, DayPickerSingleDateController: Snap to new date if date is off screen#1481ljharb merged 1 commit intoreact-dates:masterfrom
DayPicker, DayPickerSingleDateController: Snap to new date if date is off screen#1481ljharb merged 1 commit intoreact-dates:masterfrom
Conversation
…if date is off screen Fixes react-dates#1320. Co-authored-by: Jay Swain <github@jayswain.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Contributor
|
This looks legit from an eyeball inspection to me! I'll pull it down sometime this week and give it some run. |
|
Any idea when this will be released? |
Contributor
Author
|
There was another approach that looked like was more accepted but it also fizzled out. see #1487 |
|
I'd also find this very useful! |
ljharb
approved these changes
Sep 29, 2021
Member
ljharb
left a comment
There was a problem hiding this comment.
This looks great; I'll rebase this and land it if tests pass.
DayPicker, DayPickerSingleDateController: Snap to new date if date is off screen
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 79.88% 80.14% +0.26%
==========================================
Files 57 57
Lines 2287 2292 +5
Branches 635 636 +1
==========================================
+ Hits 1827 1837 +10
+ Misses 271 267 -4
+ Partials 189 188 -1
Continue to review full report at Codecov.
|
5577888 to
7490089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1320
Please review and let me know if theres any additional work you'd like completed, or if you'd like it done a different way, or, if everything is horrible 👹