Merged
Conversation
* Add Typescript tooling via react-overlays * Add @types/ via akx/autotypes * Mostly mechanically merge JavaScript and TypeScript files * Fix typings in all TS files * BootstrapModalManager: add types + fix marging -> margin typo * Amend test and build configuration * Address some review comments * Address more review comments * Move simple-types-test into tests/ and fix things to have it typecheck * Update dev deps for e.g. Eslint 7+ compat & fix type issues
taion
approved these changes
Jun 24, 2020
kyletsang
approved these changes
Jun 29, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.