BootstrapModalManager: fix typo marging -> margin#5149
Merged
taion merged 1 commit intoreact-bootstrap:masterfrom Apr 27, 2020
Merged
BootstrapModalManager: fix typo marging -> margin#5149taion merged 1 commit intoreact-bootstrap:masterfrom
taion merged 1 commit intoreact-bootstrap:masterfrom
Conversation
mxschmitt
approved these changes
Apr 27, 2020
Member
mxschmitt
left a comment
There was a problem hiding this comment.
That could be the reason why I was never able to write a test for that lol. Good catch!
taion
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while working on TypeScript typings 😄