The README mentions that you can run the tests with buck test //:CSSLayout. Does this run the Java tests as well?

@rigdern I'll update the readme with java testing as well. buck test //:CSSLayout_java will run the java tests

Could you please rebase again? I'm back from vacation now and would be happy to merge this

@rigdern Did you get a change to rebase this?

@emilsjolander Sorry for the delay. We're having some discussion in react/react-native#8619 about the right solution in that PR. Depending on the outcome of that discussion, this PR might not be needed. If it's alright with you, I'd like to have this PR sit here until we come to a conclusion on react/react-native#8619.

If you prefer, I can close this PR and reopen it later if it's needed.

No, keep it open :) just wanted a status update. Thanks!
On Wed, 10 Aug 2016 at 23:28, Adam Comella notifications@github.com wrote:

@emilsjolander https://github.com/emilsjolander Sorry for the delay.
We're having some discussion in react/react-native#8619
react/react-native#8619 about the right
solution in that PR. Depending on that outcome of that discussion, this PR
might not be needed. If it's alright with you, I'd like to have this PR sit
here until we come to a conclusion on react/react-native#8619
react/react-native#8619.

If you prefer, I can close this PR and reopen it later if it's needed.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#212 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdIpGc3-PNSNaE_Mn7U4hLTwDkbhvhyks5qelCVgaJpZM4JWq-n
.

@rigdern Any update on this? I checked the linked PR but not much has happened in a while

I'm closing this. Feel free to open another pull request later if you want 👍