[standards] Migrate "androidTest" JS from Haste to path-based requires#24813
Closed
ide wants to merge 1 commit into
Closed
[standards] Migrate "androidTest" JS from Haste to path-based requires#24813ide wants to merge 1 commit into
ide wants to merge 1 commit into
Conversation
The files in `ReactAndroid/src/androidTest/js` use Haste names; this commit migrates them to use path-based imports. This helps us move RN towards standard path-based requires. All the requires in `androidTest` have been rewritten to use relative requires. Test Plan: Run lint, Flow, and Android tests: ``` node cli.js bundle --platform android --dev true --entry-file ReactAndroid/src/androidTest/js/TestBundle.js --bundle-output ReactAndroid/src/androidTest/assets/AndroidTestBundle.js buck install ReactAndroid/src/androidTest/buck-runner:instrumentation-tests ```
Closed
12 tasks
analysis-bot
suggested changes
May 11, 2019
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
facebook-github-bot
approved these changes
May 13, 2019
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cpojer
reviewed
May 14, 2019
| const React = require('react'); | ||
| const {NativeModules, Text} = require('react-native'); | ||
|
|
||
| const {Recording: RecordingModule} = NativeModules; |
Contributor
There was a problem hiding this comment.
This should be InitialPropsRecordingModule.
I am fixing it internally, just commenting here for posterity.
Collaborator
|
This pull request was successfully merged by @ide in cd9adda. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The files in
ReactAndroid/src/androidTest/jsuse Haste names; this commit migrates them to use path-based imports. This helps us move RN towards standard path-based requires. All the requires inandroidTesthave been rewritten to use relative requires.Changelog
[General] [Changed] - Migrate "androidTest" JS from Haste to path-based requires
Test Plan
Run lint, Flow, and Android tests:
Also run CI.