Skip to content

ci: add workflow for running the eslint plugin e2e tests#32397

Merged
poteto merged 1 commit into
react:mainfrom
michaelfaith:ci/add-eslint-e2e-testing-to-ci
Feb 16, 2025
Merged

ci: add workflow for running the eslint plugin e2e tests#32397
poteto merged 1 commit into
react:mainfrom
michaelfaith:ci/add-eslint-e2e-testing-to-ci

Conversation

@michaelfaith

@michaelfaith michaelfaith commented Feb 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change adds a workflow for PR builds, that runs the e2e tests for eslint-plugin-react-hooks created in #32396

screenshot of ci tests running

@react-sizebot

react-sizebot commented Feb 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Comparing: be91130f184f04c6e7bb9ff18222aba2ef2f96f6...0f5da2b881dce87819a567a766714c90059d1a53

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.49 kB 110.49 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.75 kB 94.56 kB = 22.57 kB 15.31 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.66 kB 84.44 kB = 22.52 kB 14.95 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.75 kB 94.56 kB = 22.57 kB 15.31 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.66 kB 84.44 kB = 22.52 kB 14.95 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB

Generated by 🚫 dangerJS against a61ea0c

@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from 0da79c1 to 1350888 Compare February 16, 2025 20:22
@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from 1350888 to 20d0749 Compare February 16, 2025 20:31
@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from 20d0749 to 87ade85 Compare February 16, 2025 20:38
@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from 78d343b to b5ea36b Compare February 16, 2025 21:04
@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from b5ea36b to 4c82854 Compare February 16, 2025 21:09
@michaelfaith michaelfaith marked this pull request as ready for review February 16, 2025 21:14
poteto
poteto reviewed Feb 16, 2025
View reviewed changes
Comment thread .github/workflows/eslint_plugin_e2e_tests.yml
Comment thread .github/workflows/eslint_plugin_e2e_tests.yml Outdated
Comment thread .github/workflows/eslint_plugin_e2e_tests.yml Outdated
poteto
poteto reviewed Feb 16, 2025
View reviewed changes
Comment thread .github/workflows/eslint_plugin_e2e_tests.yml Outdated
@michaelfaith
ci: add workflow for running the eslint plugin e2e tests
a61ea0c 
This change adds a workflow for PR builds, that runs the e2e tests for `eslint-plugin-react-hooks` created in react#32396
@michaelfaith michaelfaith force-pushed the ci/add-eslint-e2e-testing-to-ci branch from 4c82854 to a61ea0c Compare February 16, 2025 21:36
@michaelfaith

michaelfaith commented Feb 16, 2025

Copy link
Copy Markdown
Contributor Author

Updated to address the feedback items

@poteto poteto merged commit eb1f77d into react:main Feb 16, 2025
@michaelfaith michaelfaith deleted the ci/add-eslint-e2e-testing-to-ci branch February 16, 2025 22:43
This was referenced Feb 19, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@poteto poteto poteto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelfaith @react-sizebot @poteto @facebook-github-bot