Update Yarn to version Berry by tiziodcaio · Pull Request #24301 · react/react

tiziodcaio · 2022-04-07T20:39:13Z

Summary

I upgraded to yarn v4.0.0, which would not work anymore on nodejs <18.

How did you test this change?

Not everything works at the moment so I make the PR a draft.

Current Issues:

We're facing many fails due to issue [Bug]: yarn install silently stops if memory is set too low in a CI environment yarnpkg/berry#3996... Hoping that it will resolve soon

kachkaev · 2022-04-08T11:23:45Z

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

tiziodcaio · 2022-04-08T11:41:09Z

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

Ok no problem, meanwhile I will fix workflows...

Can I suggest yarn upgrade-interactive as an alternative solution?

sizebot · 2022-04-08T13:09:41Z

Comparing: 2655c93...7f9136f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	154.33 kB	154.33 kB	=	48.98 kB	48.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	156.25 kB	156.25 kB	=	49.60 kB	49.60 kB
facebook-www/ReactDOM-prod.classic.js	=	533.14 kB	533.14 kB	=	94.42 kB	94.42 kB
facebook-www/ReactDOM-prod.modern.js	=	518.24 kB	518.24 kB	=	92.24 kB	92.24 kB
facebook-www/ReactDOMForked-prod.classic.js	=	533.14 kB	533.14 kB	=	94.42 kB	94.42 kB
oss-experimental/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable-semver/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable-semver/react-is/umd/react-is.production.min.js	=	2.31 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-stable/react-is/umd/react-is.production.min.js	=	2.31 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-experimental/react-is/umd/react-is.production.min.js	=	2.34 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js	=	2.27 kB	0.32 kB	=	0.78 kB	0.23 kB
oss-stable/react-is/cjs/react-is.production.min.js	=	2.27 kB	0.32 kB	=	0.78 kB	0.23 kB
oss-experimental/react-is/cjs/react-is.production.min.js	=	2.30 kB	0.32 kB	=	0.79 kB	0.23 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js	=	4.78 kB	0.32 kB	=	1.15 kB	0.24 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js	=	4.78 kB	0.32 kB	=	1.15 kB	0.24 kB
facebook-www/ReactIs-prod.classic.js	=	5.35 kB	0.34 kB	=	1.31 kB	0.25 kB
facebook-www/ReactIs-prod.modern.js	=	5.35 kB	0.34 kB	=	1.31 kB	0.25 kB
oss-stable-semver/react-is/umd/react-is.development.js	=	7.88 kB	0.45 kB	=	2.09 kB	0.29 kB
oss-stable/react-is/umd/react-is.development.js	=	7.88 kB	0.45 kB	=	2.09 kB	0.29 kB
oss-experimental/react-is/umd/react-is.development.js	=	7.90 kB	0.45 kB	=	2.10 kB	0.29 kB
oss-stable-semver/react-is/cjs/react-is.development.js	=	7.33 kB	0.41 kB	=	2.01 kB	0.28 kB
oss-stable/react-is/cjs/react-is.development.js	=	7.33 kB	0.41 kB	=	2.01 kB	0.28 kB
oss-experimental/react-is/cjs/react-is.development.js	=	7.35 kB	0.41 kB	=	2.01 kB	0.28 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js	=	7.25 kB	0.39 kB	=	1.92 kB	0.28 kB
facebook-www/ReactIs-dev.modern.js	=	9.56 kB	0.40 kB	=	2.53 kB	0.29 kB
facebook-www/ReactIs-dev.classic.js	=	9.56 kB	0.40 kB	=	2.54 kB	0.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable-semver/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable/react/unstable-cache.js	+∞%	0.00 kB	0.22 kB	+∞%	0.00 kB	0.16 kB
oss-stable-semver/react-is/umd/react-is.production.min.js	=	2.31 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-stable/react-is/umd/react-is.production.min.js	=	2.31 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-experimental/react-is/umd/react-is.production.min.js	=	2.34 kB	0.41 kB	=	0.87 kB	0.28 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js	=	2.27 kB	0.32 kB	=	0.78 kB	0.23 kB
oss-stable/react-is/cjs/react-is.production.min.js	=	2.27 kB	0.32 kB	=	0.78 kB	0.23 kB
oss-experimental/react-is/cjs/react-is.production.min.js	=	2.30 kB	0.32 kB	=	0.79 kB	0.23 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js	=	4.78 kB	0.32 kB	=	1.15 kB	0.24 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js	=	4.78 kB	0.32 kB	=	1.15 kB	0.24 kB
facebook-www/ReactIs-prod.classic.js	=	5.35 kB	0.34 kB	=	1.31 kB	0.25 kB
facebook-www/ReactIs-prod.modern.js	=	5.35 kB	0.34 kB	=	1.31 kB	0.25 kB
oss-stable-semver/react-is/umd/react-is.development.js	=	7.88 kB	0.45 kB	=	2.09 kB	0.29 kB
oss-stable/react-is/umd/react-is.development.js	=	7.88 kB	0.45 kB	=	2.09 kB	0.29 kB
oss-experimental/react-is/umd/react-is.development.js	=	7.90 kB	0.45 kB	=	2.10 kB	0.29 kB
oss-stable-semver/react-is/cjs/react-is.development.js	=	7.33 kB	0.41 kB	=	2.01 kB	0.28 kB
oss-stable/react-is/cjs/react-is.development.js	=	7.33 kB	0.41 kB	=	2.01 kB	0.28 kB
oss-experimental/react-is/cjs/react-is.development.js	=	7.35 kB	0.41 kB	=	2.01 kB	0.28 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js	=	7.25 kB	0.39 kB	=	1.92 kB	0.28 kB
facebook-www/ReactIs-dev.modern.js	=	9.56 kB	0.40 kB	=	2.53 kB	0.29 kB
facebook-www/ReactIs-dev.classic.js	=	9.56 kB	0.40 kB	=	2.54 kB	0.29 kB

Generated by 🚫 dangerJS against 7f9136f

tiziodcaio · 2022-04-14T14:17:03Z

Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297

That's not true... I didn't enable pnp so there would not be problems with this type of issue.

tiziodcaio · 2022-04-14T14:19:07Z

Now we should understanding what fails on the remaining workflows

kachkaev · 2022-04-14T18:21:47Z

Dependabot is not compatible with Yarn 3’s yarn.lock format. Unfortunately, it does not work with nodeLinker: node-modules too.

larixer · 2022-11-15T10:27:10Z

Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022:
https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/
Also the issue for Yarn 3 support in dependabot is now closed:
dependabot/dependabot-core#5322

Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features:
dependabot/dependabot-core#6092
dependabot/dependabot-core#6107

tiziodcaio · 2022-11-15T13:00:40Z

Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022: https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/ Also the issue for Yarn 3 support in dependabot is now closed: dependabot/dependabot-core#5322

Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features: dependabot/dependabot-core#6092 dependabot/dependabot-core#6107

Great! I wasn't more following this pr, now i will rebase, let's see what's happening with yarn 4 too

tiziodcaio · 2024-01-01T17:32:48Z

To check if the lockfiles are updated, i use this script (fishshell)

for file in (find . -name "yarn.lock" | grep -v "node_modules")
   set dir (dirname $file)
   echo $dir
   cd $dir
   rm -rf node_modules .yarn yarn.lock
   wget https://raw.githubusercontent.com/facebook/react/main/{$dir}/yarn.lock
   yarn
   yarn dedupe # just in case you are interested into deduping lockfiles.
   prevd
end

react-sizebot · 2024-05-05T16:16:35Z

The size diff is too large to display in a single comment. The CircleCI job contains an artifact called "sizebot-message.md" with the full message.

Generated by 🚫 dangerJS against 87e59ab

@ustayready

github-actions · 2024-08-03T17:04:07Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

tiziodcaio · 2024-08-03T18:38:47Z

Bump

vercel · 2024-09-05T15:14:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 29, 2024 10:49am

- Use corepack - Add hardlinks-global field - Deduplicate

rickhanlonii · 2025-01-06T02:35:55Z

Thanks but we all use yarn 1 and it works great

tiziodcaio · 2025-01-06T05:11:50Z

Thanks but we all use yarn 1 and it works great

K finally an answer by the team! Thank you for the chance! It was a nice challenge to maintain this!

facebook-github-bot added the CLA Signed label Apr 7, 2022

tiziodcaio marked this pull request as draft April 14, 2022 14:19

0xdevalias mentioned this pull request Jul 12, 2022

Is AppVeyor still used to test against Windows, can it be moved to CircleCI, and/or can we update it to use a modern/supported version of Node? #24891

Closed

larixer reviewed Nov 18, 2022

View reviewed changes

Comment thread .yarnrc.yml Outdated

larixer reviewed Nov 18, 2022

View reviewed changes

Comment thread .yarnrc.yml Outdated

tiziodcaio marked this pull request as ready for review November 27, 2022 14:04

tiziodcaio marked this pull request as draft October 23, 2023 20:52

tiziodcaio marked this pull request as ready for review January 2, 2024 10:54

github-actions Bot added the Resolution: Stale Automatically closed due to inactivity label Aug 3, 2024

github-actions Bot removed the Resolution: Stale Automatically closed due to inactivity label Aug 3, 2024

vercel Bot had a problem deploying to Preview September 5, 2024 15:19 Failure

vercel Bot had a problem deploying to Preview September 5, 2024 15:36 Failure

vercel Bot had a problem deploying to Preview September 5, 2024 15:43 Failure

vercel Bot had a problem deploying to Preview September 9, 2024 10:34 Failure

vercel Bot had a problem deploying to Preview September 9, 2024 10:38 Failure

tiziodcaio marked this pull request as draft September 10, 2024 21:27

vercel Bot had a problem deploying to Preview September 10, 2024 21:33 Failure

vercel Bot had a problem deploying to Preview September 10, 2024 21:43 Failure

vercel Bot had a problem deploying to Preview September 10, 2024 22:17 Failure

vercel Bot had a problem deploying to Preview September 10, 2024 22:23 Failure

vercel Bot had a problem deploying to Preview September 10, 2024 22:35 Failure

tiziodcaio added 9 commits September 15, 2024 10:40

Update yarn to 4.4.1

832e8f1

- Use corepack - Add hardlinks-global field - Deduplicate

GH workflows

926ff6d

Fix corepack enable actions/setup-node#1027

8ce9175

Tests cli fixes

500f6b9

Codesandbox fix

a7e5f24

Yarn

3151a93

Tests

24010ac

tests

a037c05

tests

617df88

vercel Bot had a problem deploying to Preview September 15, 2024 08:49 Failure

Merge remote-tracking branch 'upstream/main'

ab2e546

vercel Bot deployed to Preview October 27, 2024 11:11 View deployment

Merge remote-tracking branch 'upstream/main'

d58df81

vercel Bot deployed to Preview December 29, 2024 10:49 View deployment

rickhanlonii closed this Jan 6, 2025

Conversation

tiziodcaio commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

Uh oh!

kachkaev commented Apr 8, 2022

Uh oh!

tiziodcaio commented Apr 8, 2022

Uh oh!

sizebot commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

tiziodcaio commented Apr 14, 2022

Uh oh!

tiziodcaio commented Apr 14, 2022

Uh oh!

kachkaev commented Apr 14, 2022

Uh oh!

larixer commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiziodcaio commented Nov 15, 2022

Uh oh!

Uh oh!

Uh oh!

tiziodcaio commented Jan 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

react-sizebot commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2024

Uh oh!

tiziodcaio commented Aug 3, 2024

Uh oh!

vercel Bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickhanlonii commented Jan 6, 2025

Uh oh!

tiziodcaio commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tiziodcaio commented Apr 7, 2022 •

edited

Loading

sizebot commented Apr 8, 2022 •

edited

Loading

larixer commented Nov 15, 2022 •

edited

Loading

tiziodcaio commented Jan 1, 2024 •

edited

Loading

react-sizebot commented May 5, 2024 •

edited

Loading

vercel Bot commented Sep 5, 2024 •

edited

Loading