Skip to content

Use babel parser rather than Babylon in extract errors#17988

Merged
trueadm merged 1 commit into
react:masterfrom
trueadm:fix-extract-codes-build
Feb 6, 2020
Merged

Use babel parser rather than Babylon in extract errors#17988
trueadm merged 1 commit into
react:masterfrom
trueadm:fix-extract-codes-build

Conversation

@trueadm

@trueadm trueadm commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

We broke extract codes at some point, likely when we upgraded Babel. To fix it we should use the @babel/parser package rather than babylon.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 6, 2020
@codesandbox-ci

codesandbox-ci Bot commented Feb 6, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a500eb:

Sandbox Source
blissful-neumann-rdluh Configuration

@sizebot

sizebot commented Feb 6, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4a500eb

@sizebot

sizebot commented Feb 6, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4a500eb

@trueadm trueadm merged commit df134d3 into react:master Feb 6, 2020
@trueadm trueadm deleted the fix-extract-codes-build branch February 6, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants