Skip to content

Update various monorepo dependencies#17901

Merged
necolas merged 3 commits into
react:masterfrom
necolas:update-deps
Jan 24, 2020
Merged

Update various monorepo dependencies#17901
necolas merged 3 commits into
react:masterfrom
necolas:update-deps

Conversation

@necolas

@necolas necolas commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

Summary

Updates various monorepo dependencies. Will update the closure compiler dependency separately.

Test Plan

yarn test

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 23, 2020
@codesandbox-ci

codesandbox-ci Bot commented Jan 23, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08caf55:

Sandbox Source
keen-river-f2msm Configuration

@sizebot

sizebot commented Jan 23, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 08caf55

@sizebot

sizebot commented Jan 23, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 08caf55

Comment thread package.json
"@babel/traverse": "^7.0.0",
"@mattiasbuelens/web-streams-polyfill": "0.1.0",
"art": "^0.10.1",
"@mattiasbuelens/web-streams-polyfill": "^0.3.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful with polyfills, as they might cause breakages if we use them in our bundle builds.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying you want me to revert this change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be okay

@necolas necolas merged commit 9d09052 into react:master Jan 24, 2020
@necolas necolas deleted the update-deps branch January 24, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants