Skip to content

Renamed "ReactDOM-fb" imports to "ReactDOM" in www shims#17797

Merged
bvaughn merged 2 commits into
react:masterfrom
bvaughn:ReactDOM-fb
Jan 7, 2020
Merged

Renamed "ReactDOM-fb" imports to "ReactDOM" in www shims#17797
bvaughn merged 2 commits into
react:masterfrom
bvaughn:ReactDOM-fb

Conversation

@bvaughn

@bvaughn bvaughn commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

ReactDOM-fb was recently removed in www, which would cause all of these shims to break on the next sync.

Comment thread scripts/rollup/shims/facebook-www/ReactDOMComponentTree_DO_NOT_USE.js Outdated
@codesandbox-ci

codesandbox-ci Bot commented Jan 7, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c6e47f:

Sandbox Source
interesting-bhabha-whwbo Configuration

@bvaughn bvaughn requested a review from gaearon January 7, 2020 18:26
@sizebot

sizebot commented Jan 7, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 5c6e47f

@sizebot

sizebot commented Jan 7, 2020

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 5c6e47f

@bvaughn bvaughn merged commit 6250462 into react:master Jan 7, 2020
@bvaughn bvaughn deleted the ReactDOM-fb branch January 7, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants