Remove special casing of toString values when enableTrustedTypesIntegration#17774
Merged
Conversation
As far as I can tell, the toString call was added here: react@caae627#diff-5574f655d491348f422bca600ff6711dR887 It was never really needed. Subsequently when we added Trusted Types, this needed to be changed to a special call but we really should just always let it pass through.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac96bc5:
|
Details of bundled changes.Comparing: f749045...ac96bc5 react-dom
ReactDOM: size: -0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: f749045...ac96bc5 react-dom
Size changes (experimental) |
5356ecb to
09eedd3
Compare
Contributor
Author
|
I also removed the fancy typed abstractions. They actually provide more harm than they help. It makes it seem like you should go through them to get to a string or string like object but often you should just special case it at every callsite. Like this one: https://github.com/facebook/react/pull/17322/files#r362947154 The abstractions makes it seem like it can be used in other places but it's really only useful in one place and so we should inline it in that one place. |
…ration As far as I can tell, we only toString in user space because of IE8/9. We don't really support IE8/9 anymore and by the time this flag is on, we should be able to deprecate it. Unless this is also an issue in IE11. I haven't tested yet.
09eedd3 to
ac96bc5
Compare
Collaborator
|
I think we do support IE9 when Map/Set/rAF polyfills are on. I don't think we added anything that would have broken it yet. But breaking it in 17 makes sense to me. |
gaearon
approved these changes
Jan 4, 2020
lunaruan
approved these changes
Jan 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, we only toString in user space because of IE8/9. I tested in IE10 and IE11 and it doesn't seem to be an issue there.
We don't really support IE8/9 anymore and by the time this flag is on, it should be fine to stop supporting IE8/9. Arguably it's already ok to break it since we've done so with other IE8/9 things.