Skip to content

unstable_createRoot -> createRoot in test#17107

Merged
acdlite merged 1 commit into
react:masterfrom
acdlite:fix-createroot-caller-in-test
Oct 16, 2019
Merged

unstable_createRoot -> createRoot in test#17107
acdlite merged 1 commit into
react:masterfrom
acdlite:fix-createroot-caller-in-test

Conversation

@acdlite

@acdlite acdlite commented Oct 16, 2019

Copy link
Copy Markdown
Collaborator

Fixes test added in #17105, which was based on an earlier commit than the one that removed the unstable_ prefix from createRoot.

Fixes test added in react#17105, which was based on an earler commit than the
one that removed the `unstable_` prefix from `createRoot`.
@sizebot

sizebot commented Oct 16, 2019

Copy link
Copy Markdown
Warnings
⚠️ Base commit is broken: 6ff23f2

Size changes (stable)

Generated by 🚫 dangerJS against 2b769d6

@sizebot

sizebot commented Oct 16, 2019

Copy link
Copy Markdown
Warnings
⚠️ Base commit is broken: 6ff23f2

Size changes (experimental)

Generated by 🚫 dangerJS against 2b769d6

@acdlite acdlite merged commit d7feeb2 into react:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants