chore: upgrade jsdom#17012
Closed
SimenB wants to merge 1 commit into
Closed
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Contributor
|
Bumping to extend life, this seems like one we’ll need |
Contributor
Author
|
Jest 25 is released, but you cannot upgrade due to this error |
Collaborator
- element.style.foo
+ element.style.getPropertyValue('--foo')which works in a browser. The previous test wouldn't even pass in a browser (or at least not in chrome 79). I quickly tried it on this branch but had no success. Do you have a branch with jest 25 (and jsdom 15) that I can check-out? |
Contributor
Author
|
I don't, but I can open up a separate PR for it, 2 sec |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #15778, this is needed before being able to upgrade to Jest 25, which will have some significant performance improvements. Some tests for
styleproperties are failing though, and I have no idea if it's due to jsdom or the tests themselves. I have some hope you'll know what's up yourselves 🤞I tried upgrading to the Jest 25 alpha btw, and it fails in the same way, so if it's an issue with jsdom itself, it has not been fixed for jsdom@15 and it'd be great to report it to them.
/cc @threepointone