[react-ui] Improve consistency of Tap responder#16837
Merged
Merged
Conversation
trueadm
approved these changes
Sep 20, 2019
trueadm
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I was thinking separately, we should probably export the properties of buttonsEnum separately rather than referencing them from an object - so we can save a few more bytes by inlining the values.
Makes sure that touch events with modifier keys behave the same way as other pointer types (i.e., does not call `onTapStart` if the gesture begins with a modifier key held down)
0123769 to
1d8602b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure that touch events with modifier keys behave the same way as other
pointer types (i.e., does not call
onTapStartif the gesture begins with amodifier key held down)