Skip to content

Change trackedTouchCount console.error to warn#16750

Merged
cpojer merged 1 commit into
react:masterfrom
ascorbic:warn-for-touch-events
Sep 11, 2019
Merged

Change trackedTouchCount console.error to warn#16750
cpojer merged 1 commit into
react:masterfrom
ascorbic:warn-for-touch-events

Conversation

@ascorbic

Copy link
Copy Markdown
Contributor

This is a workaround for an Android OS bug causing errors in React Native.

The very old bug react/react-native#15059 is caused by certain Android builds' handling of three-finger screenshots. The OS sends three touchcancel events, but only two touchstart events. This causes unavoidable red box errors. This PR changes the console.error to console.warn. This behaviour is consistent with similar touch event errors.

@sizebot

sizebot commented Sep 11, 2019

Copy link
Copy Markdown

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 0f1d33d

@cpojer cpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants