Enable MessageLoop implementation by default#16408
Merged
Merged
Conversation
|
React: size: -2.3%, gzip: -3.1% Details of bundled changes.Comparing: 868d02d...d61c6cc react
scheduler
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Aug 21, 2019
Contributor
|
Maybe we need to make sure this works on RN now? |
Collaborator
|
Let's go ahead and merge this? |
Collaborator
Author
|
Lemme check RN. What are we looking for? Just that effects fire? |
|
React: size: -2.2%, gzip: -2.8% Details of bundled changes.Comparing: 79e46b6...1773240 react
scheduler
|
Collaborator
Author
|
I tested on RN a bit. useEffect works. |
famous last words 😄 |
|
Is this change published on the latest or any of the pre-releases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the RAF scheduler impl in favor of the MessageLoop one, which we've found better utilizes CPU. Unlike #16271, this keeps the RAF implementation for now just in case, but it's only in one specially marked test.
This matches what we already rolled out in www, except the rAF-specific flags (they're true on www but they're dead code in the rAF path anyway — and I didn't want to adjust the test for them).
My previous PR includes most of the extra test coverage for ML scheduler which I picked up from Andrew's earlier PR.