Remove "Waiting for async callback" User Timing measurement#16379
Merged
Conversation
Collaborator
Author
|
The test warning I added uncovered a problem in production mode which is fixed by the second commit. Note that it doesn't affect open source, but it affects Ads which uses User Timing for a subset of users in prod environment. |
bvaughn
approved these changes
Aug 13, 2019
bvaughn
left a comment
Contributor
There was a problem hiding this comment.
This makes debugging very annoying because "break on caught exceptions" stops there all the time.
This drives me batty.
Others might want to weigh in on this too, but I'm in favor of axing it 👍
Collaborator
Author
|
@acdlite said he has a WIP replacement for this on Scheduler level anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This measurement is already broken (mark/measure calls for it mismatch in Concurrent Mode). This makes debugging very annoying because "break on caught exceptions" stops there all the time.
It's difficult to keep it up to date because it models a pause rather than an actual work slice. This is why we keep breaking it. I propose that we just remove this timing, and fix it forward with Root Events.