Skip to content

Add missing check to unmocked Scheduler warning#16261

Merged
acdlite merged 1 commit into
react:masterfrom
acdlite:unmocked-scheduler-check
Jul 31, 2019
Merged

Add missing check to unmocked Scheduler warning#16261
acdlite merged 1 commit into
react:masterfrom
acdlite:unmocked-scheduler-check

Conversation

@acdlite

@acdlite acdlite commented Jul 31, 2019

Copy link
Copy Markdown
Collaborator

The unmocked Scheduler warning doesn't actually check if Scheduler is mocked.

Only affects www because the warnAboutUnmockedScheduler feature flag is off in the open source build.

The unmocked Scheduler warning doesn't actually check if Scheduler
is mocked.
@sizebot

sizebot commented Jul 31, 2019

Copy link
Copy Markdown

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@acdlite

acdlite commented Jul 31, 2019

Copy link
Copy Markdown
Collaborator Author

Merging to unblock sync

@acdlite acdlite merged commit 3756167 into react:master Jul 31, 2019
@threepointone

Copy link
Copy Markdown
Contributor

Sorry! 😣 Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants