Skip to content

React Events: FocusScope tweaks and docs#15515

Merged
necolas merged 2 commits into
react:masterfrom
necolas:react-events/focus-scope-and-docs
Apr 26, 2019
Merged

React Events: FocusScope tweaks and docs#15515
necolas merged 2 commits into
react:masterfrom
necolas:react-events/focus-scope-and-docs

Conversation

@necolas

@necolas necolas commented Apr 26, 2019

Copy link
Copy Markdown
Contributor
  • FocusScope: rename trap to contain.
  • FocusScope: avoid potential for el.focus() errors.
  • FocusScope: add docs,
  • Update docs formatting,

@trueadm trueadm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@necolas necolas merged commit cc5a493 into react:master Apr 26, 2019
@necolas necolas deleted the react-events/focus-scope-and-docs branch May 3, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants