React events: consolidate logic of Hover event component#15450
Merged
Conversation
trueadm
approved these changes
Apr 19, 2019
trueadm
reviewed
Apr 19, 2019
trueadm
left a comment
Contributor
There was a problem hiding this comment.
The CI seems to be failing here.
Contributor
Author
|
It should start passing once I merge the commit it depends on |
f6272a8 to
fd689e6
Compare
Details of bundled changes.Comparing: 5857c89...fd689e6 react-events
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #15449. Demo integrating this patch: https://fburl.com/nfye4390
Minor refactor of
Hoverand additional regression coverage.Ref #15257