Fix CI#15393
Merged
Merged
Conversation
Collaborator
Author
|
Ok this is what I would expect to see:
It can't find the build artifact for |
Collaborator
Author
|
It fails because the base commit is broken... I suppose I should make that a warn instead :D |
Collaborator
Author
|
Ok I think this will fix master. I'll merge and see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently failing. I think it's because I pushed a commit directly to master without first opening a PR. Generally we shouldn't do this, but sometimes it makes sense, like if you want to merge a branch without squashing the commits.
I'll use this branch to try out some strategies for fixing it.