React events: add onHoverMove support#15388
Merged
Merged
Conversation
trueadm
reviewed
Apr 11, 2019
trueadm
approved these changes
Apr 11, 2019
trueadm
left a comment
Contributor
There was a problem hiding this comment.
I left feedback on hover move being discrete. Also we should probably add onUnmount support to the Hover module to make it unsubscribe from events properly at some point too.
05a5bf6 to
6bf944a
Compare
6bf944a to
bb9988d
Compare
Details of bundled changes.Comparing: cdfb06e...bb9988d react-events
Generated by 🚫 dangerJS |
|
Is it really OK that it does not respect the shape of an element? Suppose we have an element with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
onHoverMove, related test, and documentation.Ref #15257