Skip to content

Add delay props to Hover event module#15325

Merged
trueadm merged 3 commits into
react:masterfrom
necolas:react-events/hover-delay-props
Apr 5, 2019
Merged

Add delay props to Hover event module#15325
trueadm merged 3 commits into
react:masterfrom
necolas:react-events/hover-delay-props

Conversation

@necolas

@necolas necolas commented Apr 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds support for delayHoverStart and delayHoverEnd. The behaviour is specced by the additional unit tests.

Ref #15257

@necolas necolas requested a review from trueadm April 4, 2019 20:37
trueadm
trueadm approved these changes Apr 4, 2019
View reviewed changes

@trueadm trueadm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase. :)

@necolas necolas force-pushed the react-events/hover-delay-props branch from dfaf560 to 19add40 Compare April 4, 2019 23:24
@necolas necolas force-pushed the react-events/hover-delay-props branch from 19add40 to 7002a49 Compare April 4, 2019 23:25
@react react deleted a comment from sizebot Apr 5, 2019
@sizebot

sizebot commented Apr 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Details of bundled changes.

Comparing: 49595e9...6c7069a

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% -0.3% 1.16 KB 1.16 KB 619 B 617 B UMD_DEV
react-events.development.js 0.0% -0.2% 996 B 996 B 556 B 555 B NODE_DEV
react-events-press.development.js 0.0% 0.0% 11.22 KB 11.22 KB 2.72 KB 2.72 KB NODE_DEV
react-events-press.production.min.js 0.0% -0.1% 4.25 KB 4.25 KB 1.52 KB 1.52 KB NODE_PROD
react-events-hover.development.js +24.3% +19.1% 5.26 KB 6.54 KB 1.46 KB 1.74 KB UMD_DEV
react-events-hover.production.min.js 🔺+30.8% 🔺+24.7% 2.26 KB 2.96 KB 946 B 1.15 KB UMD_PROD
react-events-hover.development.js +25.1% +19.7% 5.09 KB 6.37 KB 1.42 KB 1.7 KB NODE_DEV
react-events-hover.production.min.js 🔺+33.2% 🔺+25.8% 2.1 KB 2.8 KB 883 B 1.08 KB NODE_PROD
ReactEventsHover-dev.js +26.2% +19.1% 5.07 KB 6.4 KB 1.43 KB 1.71 KB FB_WWW_DEV
ReactEventsHover-prod.js 🔺+35.0% 🔺+30.8% 4.23 KB 5.72 KB 1.09 KB 1.43 KB FB_WWW_PROD
react-events-focus.production.min.js 0.0% -0.1% 1.52 KB 1.52 KB 740 B 739 B UMD_PROD
react-events-focus.production.min.js 0.0% -0.1% 1.35 KB 1.35 KB 673 B 672 B NODE_PROD
react-events-swipe.development.js +0.1% 0.0% 8.28 KB 8.29 KB 2.57 KB 2.57 KB UMD_DEV
react-events-swipe.production.min.js 🔺+0.1% 🔺+0.1% 3.45 KB 3.46 KB 1.61 KB 1.61 KB UMD_PROD
react-events-swipe.development.js +0.1% 0.0% 8.11 KB 8.12 KB 2.53 KB 2.53 KB NODE_DEV
react-events-swipe.production.min.js 🔺+0.1% 🔺+0.1% 3.29 KB 3.29 KB 1.55 KB 1.55 KB NODE_PROD
ReactEventsSwipe-dev.js +0.1% 0.0% 6.2 KB 6.21 KB 1.78 KB 1.78 KB FB_WWW_DEV
ReactEventsSwipe-prod.js 🔺+0.6% 🔺+0.3% 5.92 KB 5.96 KB 1.54 KB 1.54 KB FB_WWW_PROD
react-events-drag.development.js 0.0% -0.0% 7.8 KB 7.8 KB 2.44 KB 2.44 KB UMD_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.3 KB 3.3 KB 1.5 KB 1.5 KB UMD_PROD
react-events-drag.development.js 0.0% 0.0% 7.63 KB 7.63 KB 2.4 KB 2.4 KB NODE_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.14 KB 3.14 KB 1.44 KB 1.44 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 958b617 into react:master Apr 5, 2019
@necolas necolas deleted the react-events/hover-delay-props branch May 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@necolas @sizebot @trueadm @facebook-github-bot