Skip to content

React events: keyboard press, types, tests#15314

Merged
necolas merged 8 commits into
react:masterfrom
necolas:react-events/hover-focus-press
Apr 4, 2019
Merged

React events: keyboard press, types, tests#15314
necolas merged 8 commits into
react:masterfrom
necolas:react-events/hover-focus-press

Conversation

@necolas

@necolas necolas commented Apr 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

I suggest reviewing this by stepping through the individual commits. This patch addresses the following tasks:

  • Adding flow types for Hover and Focus props.
  • Improved Hover and Press test coverage.
  • Reducing the default length of delayLongPress.
  • Adds keyboard support for all the press events.

Ref #15257

@necolas necolas requested a review from trueadm April 3, 2019 23:55
@sizebot

sizebot commented Apr 4, 2019

Copy link
Copy Markdown
Details of bundled changes.

Comparing: 6d0effa...dfad2b9

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% +0.2% 1.16 KB 1.16 KB 615 B 616 B UMD_DEV
react-events.development.js 0.0% +0.2% 996 B 996 B 553 B 554 B NODE_DEV
react-events-press.development.js +6.3% +2.8% 10.21 KB 10.86 KB 2.62 KB 2.69 KB UMD_DEV
react-events-press.production.min.js 🔺+4.4% 🔺+1.8% 4.03 KB 4.21 KB 1.5 KB 1.53 KB UMD_PROD
react-events-press.development.js +6.4% +3.0% 10.04 KB 10.69 KB 2.57 KB 2.65 KB NODE_DEV
react-events-press.production.min.js 🔺+4.6% 🔺+1.5% 3.87 KB 4.04 KB 1.45 KB 1.48 KB NODE_PROD
ReactEventsPress-dev.js +4.6% +2.9% 10.42 KB 10.9 KB 2.61 KB 2.69 KB FB_WWW_DEV
ReactEventsPress-prod.js 🔺+6.8% 🔺+1.1% 7.92 KB 8.46 KB 1.9 KB 1.92 KB FB_WWW_PROD
react-events-hover.development.js +1.3% +3.5% 5.18 KB 5.24 KB 1.41 KB 1.46 KB UMD_DEV
react-events-hover.production.min.js -0.1% -0.4% 2.28 KB 2.28 KB 943 B 939 B UMD_PROD
react-events-hover.development.js +1.3% +3.7% 5.01 KB 5.07 KB 1.37 KB 1.42 KB NODE_DEV
react-events-hover.production.min.js -0.2% -0.4% 2.12 KB 2.12 KB 889 B 885 B NODE_PROD
ReactEventsHover-dev.js +1.0% +4.1% 5.02 KB 5.06 KB 1.37 KB 1.42 KB FB_WWW_DEV
ReactEventsHover-prod.js -0.3% -0.6% 4.2 KB 4.19 KB 1.12 KB 1.11 KB FB_WWW_PROD
react-events-focus.development.js -1.7% -0.1% 3.39 KB 3.34 KB 1.11 KB 1.11 KB UMD_DEV
react-events-focus.production.min.js 0.0% 🔺+0.1% 1.55 KB 1.55 KB 746 B 747 B UMD_PROD
react-events-focus.development.js -1.8% 0.0% 3.22 KB 3.17 KB 1.06 KB 1.06 KB NODE_DEV
ReactEventsFocus-dev.js -1.8% +0.4% 3.19 KB 3.13 KB 1.05 KB 1.05 KB FB_WWW_DEV
react-events-swipe.development.js 0.0% -0.0% 8.31 KB 8.31 KB 2.57 KB 2.56 KB UMD_DEV
react-events-swipe.development.js 0.0% -0.0% 8.14 KB 8.14 KB 2.53 KB 2.53 KB NODE_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.31 KB 3.31 KB 1.55 KB 1.55 KB NODE_PROD

Generated by 🚫 dangerJS

trueadm
trueadm approved these changes Apr 4, 2019
View reviewed changes

@trueadm trueadm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@necolas necolas merged commit 937d262 into react:master Apr 4, 2019
@necolas necolas deleted the react-events/hover-focus-press branch May 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@necolas @sizebot @trueadm @facebook-github-bot