Add tests for Press responder event module#15290
Merged
Merged
Conversation
c21ba8d to
40462ad
Compare
added 2 commits
April 2, 2019 07:40
Behavior being tested takes cues from React Native's Pressability. A couple of these tests fail and require the Press implementation to be patched. Ref react#15257
40462ad to
0d4127c
Compare
trueadm
approved these changes
Apr 2, 2019
trueadm
left a comment
Contributor
There was a problem hiding this comment.
These tests are great, they'll help us move faster with the Press implementation too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for every implemented prop and feature of the Press responder event module.
Patches the Press module to fix two failing tests: default
delayLongPresscannot be shorter than 10ms;onPressChangetiming should not change ifonPressis cancelled byonLongPressShouldCancelPress.NOTE: The default longPress delay should be
500to match Android and React Native - https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewConfiguration.java#66. This will be fixed once #15288 is mergedRef #15257