Fix longpress in experimental Press event module#15246
Merged
Merged
Conversation
The 'longpress' event is dispatched during a press interaction, rather than after it has ended. The 'longPressCancelsPress' prop can be used to prevent 'press' being dispatched if 'longpress' has already been dispatched.
trueadm
reviewed
Mar 28, 2019
trueadm
approved these changes
Mar 28, 2019
trueadm
left a comment
Contributor
There was a problem hiding this comment.
Looks good minus the typo on the comment.
Details of bundled changes.Comparing: fb6b508...981463d react-events
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
longpressevent is dispatched during a press interaction, rather than after it has ended.The
longPressCancelsPressprop can be used to prevent 'press' being dispatched iflongpresshas already been dispatched.