test(accumulate): add test suite for accumulate function#15159
Merged
Conversation
cpojer
approved these changes
Apr 25, 2019
cpojer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding a test!
Collaborator
|
We try not to add tests like this that use private APIs anymore. Instead, we test the public API. In this case, this implementation is already covered by the actual events tests. It doesn't hurt that we added this, but for the future, we made a concentrated effort to get away from these kinds of tests. Thanks for sending the PR though! I understand it's not very obvious because it doesn't match how many JS projects do testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should increase coverage a tad for the highlighted loc 👍