feat: add recommended config eslint rule#14762
Merged
Merged
Conversation
LogError: { FetchError: invalid json response body at http://react.zpao.com/builds/master/_commits/d827445a500e497712a1a404c7ccc25779b1df5c/results.json reason: Unexpected token < in JSON at position 0
at /home/circleci/project/node_modules/node-fetch/lib/body.js:48:31
at process._tickCallback (internal/process/next_tick.js:68:7)
name: 'FetchError',
message:
'invalid json response body at http://react.zpao.com/builds/master/_commits/d827445a500e497712a1a404c7ccc25779b1df5c/results.json reason: Unexpected token < in JSON at position 0',
type: 'invalid-json' }
Generated by 🚫 dangerJS |
|
Thank you for opening a PR for this! I'm presuming the CI failure is an infra issue and unrelated to this change? If so, could someone retrigger CI? :-) |
Contributor
Author
|
Rebased this and added the second rule |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by copying in the built package in a project and following the added instructions in the readme