Add a failing test for remounting fallback in sync mode#14078
Closed
gaearon wants to merge 1 commit into
Closed
Conversation
gaearon
commented
Nov 2, 2018
| 'Child 2', | ||
| 'Suspend! [Child 3]', | ||
| 'Loading...', | ||
| 'Suspend! [Child 3]', // TODO: why does this suspend twice? |
Collaborator
Author
There was a problem hiding this comment.
This was also weird
Collaborator
There was a problem hiding this comment.
It's a known flaw with sync mode. Pings aren't batched, so we get a synchronous retry for every individual ping. Added a comment in the rebased version of your test:
Details of bundled changes.Comparing: c84b9bf...de878eb scheduler
Generated by 🚫 dangerJS |
Collaborator
|
I was thinking that one solution to this would be to render the fallback in the first commit, and hide the timed out tree in the second commit. It’s annoying though because it adds so much complexity just for a legacy case. I think we should wait to see if this is a problem in practice first. |
Collaborator
Author
|
It does seem to be a problem in practice as described in #14073 — sucks for the spinner to "twitch". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a failing test for #14073.
See last line for the failing case.
I'm not actually sure it's a bug. It makes sense that if we render
nullin sync mode, we end up remounting. But it seems like far from ideal and I wonder if we can fix it.