react-dom: remove support for children content in <textarea/>#11639
react-dom: remove support for children content in <textarea/>#11639raphamorim wants to merge 1 commit into
Conversation
|
This is a breaking change so it'll need to be in React 17. |
|
Ok, I'll work on it. :) |
57766b7 to
303ef84
Compare
|
@gaearon I update tests for this change. |
0f7c328 to
3def9fb
Compare
3def9fb to
51c084d
Compare
| let children = props.children; | ||
| if (children != null) { | ||
| if (__DEV__) { | ||
| warning( |
There was a problem hiding this comment.
Maybe the warning should be kept (or converted into an error) in 17.0? I know that this is technically a breaking change that warns already, but having an explicit use value instead of children warning would avoid confusing debugging. Shouldn't be any perf impact if it's dev-only too, right?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Let me know if I need to test/coverage some case.