Warn on missing Set/Map polyfills#10356
Merged
Merged
Conversation
Contributor
|
In the past these were warnings. https://github.com/facebook/react/blob/master/src/renderers/dom/ReactDOMStackEntry.js#L131 |
Collaborator
Author
|
See above:
Wanna change this for rAF to also be a warning? |
Collaborator
Author
|
I changed Map/Set to be a warning but left |
Collaborator
Author
|
Changed rAF check to also be a warning in last commit. |
sebmarkbage
approved these changes
Aug 2, 2017
sebmarkbage
reviewed
Aug 2, 2017
| @@ -25,6 +25,21 @@ import type {Deadline} from 'ReactFiberReconciler'; | |||
| var invariant = require('fbjs/lib/invariant'); | |||
Contributor
There was a problem hiding this comment.
This is now unused. rm to fix lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an early check with a URL currently pointing to a gist.
We’ll move this to docs as part of 16 release.
We could do a warning instead, which would save some bytes.
I opted for invariant for consistency with what we do for rAFs.Changed this to be a warning per feedback.I check for specific methods we use. There’s some earlier versions of Firefox that added support gradually.