Skip to content

[DevTools] Use line number and column number to match hook #21792

@bvaughn

Description

@bvaughn

DevTools named hook parsing logic currently matches AST nodes using the original line number:
https://github.com/facebook/react/blob/ed6c091fe961a3b95e956ebcefe8f152177b1fb7/packages/react-devtools-extensions/src/parseHookNames.js#L341-L346

But this may not be sufficient, as mentioned in comment #21641 (comment):

Are we assuming that a line number is sufficient to identify a hook call? Seems like that assumption breaks down in edge cases:

  1. Minified code (either without a source map, or a bundle built from pre-minified inputs) can have multiple hooks on one line.
  2. Some code might be authored with quirky formatting, i.e. not with a typical Prettier / ESLint setup.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions