ci(deps-dev): bump electron from 40.10.0 to 42.1.0#21
Merged
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
1cecbd4 to
68957b1
Compare
Owner
|
Contributor
Author
|
A newer version of electron exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [electron](https://github.com/electron/electron) from 40.10.0 to 42.1.0. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v40.10.0...v42.1.0) --- updated-dependencies: - dependency-name: electron dependency-version: 41.5.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The electron-rebuild step fails because better-sqlite3 (v12.10.0, the latest) cannot compile against Electron 42's V8 headers. Three breaking V8 API changes cause the build to fail: 1. v8::External::New(isolate, addon) now requires a 3rd argument (v8::ExternalPointerTypeTag) 2. v8::External::Value() now requires 1 argument (ExternalPointerTypeTag) 3. SetNativeDataProperty overloads are ambiguous with new signatures These are known upstream issues (WiseLibs/better-sqlite3#1474, WiseLibs/better-sqlite3#1470). The better-sqlite3 maintainers explicitly removed Electron v42 prebuild support in v12.10.0 and are working on fixing the V8 API compatibility. No caller code in this repo needs changes — the breakage is entirely in a transitive native dependency's compilation step.
Patch three V8 API breaks in better-sqlite3 C++ source that prevent compilation against Electron 42 headers (V8 14.x): 1. v8::External::New() now requires ExternalPointerTypeTag (3rd arg) 2. v8::External::Value() now requires ExternalPointerTypeTag 3. SetNativeDataProperty(0) ambiguous between new nullptr_t/setter overloads Adds a postinstall script (scripts/patch-better-sqlite3.js) to apply these patches idempotently after every npm install. Also bumps better-sqlite3 from ^12.6.2 to ^12.10.0.
2257409 to
2b81651
Compare
The patch-better-sqlite3 postinstall script introduced in the prior commit was not Prettier-formatted, causing the CI format check to fail.
Owner
✅ Dependabot PR Merged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps electron from 40.10.0 to 42.1.0.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
9604c46refactor: simplify content_view_ hit-test transparency on macOS (#51626)e229b1dperf: reduce per-call overhead in gin converters (#51607)e639fa0fix: don't return anullptrfromTargetForRect(#51605)bce23fcperf: reduce per-call overhead in gin_helper hot paths (#51614)eac794ffix: ship IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON and allow overriding it (#51594)b133532ci: pin Homebrew version in CI runs (#51545)a8a9854chore: update breaking changes for Electron 42 (#51550)e7021e3fix: test idempotency issues (#51526)e49c3c6test: make sure there are no orphaned electron processes running (#51485)90ef05bchore: bump chromium to 148.0.7778.97 (42-x-y) (#51517)