cmount: Add optional brew tag
#4782
Conversation
|
This is the error message thrown when using mount or cmount with the brew build tag: |
|
#4775 (comment) suggests a
|
|
Yep, I intend to add this caveat to the homebrew formula and not to the rclone docs. |
|
Just to clarify on this, my thought process has always been to reflect the limitations etc. of the actual binaries available on the website on the respective pages. The package-specific or OS-specific limitations should always be present in those docs, especially since Homebrew provides an easy way to add caveats in the formula. |
|
I may not understand something. Why not just fail gracefully if fuse isn't available in all builds rather than take functionality out for some builds? |
… the binaries installed via Homebrew - Fixes rclone#4775 Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
ec975a6 to
4f89c36
Compare
ncw
left a comment
There was a problem hiding this comment.
I think this is OK.
Query about whether we expect brew + cmount inline
| // Build for macos with the brew tag to handle the absence | ||
| // of fuse and print an appropriate error message | ||
|
|
||
| // +build brew |
There was a problem hiding this comment.
Does this need to mention the cmount tag? Or do we do this regardless of the cmount tag?
If we can expect cmount and brew to be set then we need to adjust the constraints for cmount/{fs,mount}.go something like:
// +build cmount
// +build cgo
// +build linux darwin,!brew freebsd windows
There was a problem hiding this comment.
I will just be replacing the cmount tag with the brew tag in Homebrew so this case probably won't happen there but I can add it anyway to be safe if you want?
There was a problem hiding this comment.
No I think that is fine. Adding too many build constraints makes my head explode anyway as there are too many combinations to think through.
|
As far as I can see we now have two options for building with brew
Option 2) would be my preference if that is OK with the brew developers, but it might not be possible as they will need FUSE installed on the dev machine to build rclone with the I note that removing OSXFUSE from brew will break rclone's build rclone/.github/workflows/build.yml Line 130 in 211b08f So we'll have to fix that too at some point! |
I don't think that's the end goal. Based on my understanding of the discussions at Homebrew/homebrew-core#64491, it is just that they are removing any formula that depends on a Cask and not the cask itself. Anyway, I will confirm this understanding once. |
|
This change has been accepted in the homebrew repository too so this PR can be merged now. |
|
Thank you @darthShadow - I'll merge this now |
cmount: Add optional
brewtag to throw an error when using mount in the binaries installed via Homebrew - Fixes #4775What is the purpose of this change?
Add optional
brewtag to throw an error when using mount in the binaries installed via HomebrewWas the change discussed in an issue or in the forum before?
#4775
Checklist