treat annotation processor dependencies the same as runtime dependencies for McProject.uses() and overshot behavior
#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy' into sealed_ConfiguredProjectDependency * origin/sealed_ConfiguredProjectDependency: expand `McProject.uses(...)` to support all `ConfiguredDependency` types make `ExternalDependency` a sealed class with runtime and codegen variants make `ConfiguredProjectDependency` a sealed class with runtime and codegen variants # Conflicts: # modulecheck-config/api/src/main/kotlin/modulecheck/config/CodeGeneratorBinding.kt # modulecheck-parsing/gradle/dsl/api/src/main/kotlin/modulecheck/parsing/gradle/dsl/DependenciesBlock.kt # modulecheck-parsing/gradle/dsl/internal/src/main/kotlin/modulecheck/parsing/gradle/dsl/internal/AbstractDependenciesBlock.kt # modulecheck-parsing/gradle/model/api-dependency/src/main/kotlin/modulecheck/parsing/gradle/model/ConfiguredDependency.kt # modulecheck-parsing/gradle/model/api-dependency/src/main/kotlin/modulecheck/parsing/gradle/model/ConfiguredProjectDependency.kt # modulecheck-project/api/src/main/kotlin/modulecheck/project/HasProjectCache.kt # modulecheck-project/testing/src/main/kotlin/modulecheck/project/test/McProjectBuilder.kt
RBusarow
added a commit
that referenced
this pull request
Jun 1, 2022
* main: Update dependency com.autonomousapps.dependency-analysis to v1.4.0 Update dependency com.osacky.doctor to v0.8.1 update website actions to use node 18.x treat annotation processor dependencies the same as runtime dependencies for `McProject.uses()` and overshot behavior (#701) Update ci.yml Update docusaurus monorepo to v2.0.0-beta.21 Update kotlinx-coroutines to v1.6.2 Update dependency com.autonomousapps.dependency-analysis to v1.3.0 Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.1 # Conflicts: # modulecheck-api/dependencies/runtimeClasspath.txt # modulecheck-config/api/dependencies/runtimeClasspath.txt # modulecheck-config/fake/dependencies/runtimeClasspath.txt # modulecheck-core/dependencies/runtimeClasspath.txt # modulecheck-core/src/main/kotlin/modulecheck/core/context/OverShotDependencies.kt # modulecheck-core/src/main/kotlin/modulecheck/core/context/UnusedDependencies.kt # modulecheck-finding/api/dependencies/runtimeClasspath.txt # modulecheck-finding/impl-android/dependencies/runtimeClasspath.txt # modulecheck-finding/impl-sort/dependencies/runtimeClasspath.txt # modulecheck-finding/impl/dependencies/runtimeClasspath.txt # modulecheck-gradle/platforms/api/dependencies/runtimeClasspath.txt # modulecheck-gradle/platforms/impl/dependencies/runtimeClasspath.txt # modulecheck-gradle/platforms/internal-android/dependencies/runtimeClasspath.txt # modulecheck-gradle/platforms/internal-jvm/dependencies/runtimeClasspath.txt # modulecheck-gradle/plugin/dependencies/runtimeClasspath.txt # modulecheck-parsing/android/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/dsl/api/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/dsl/internal/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/dsl/precompiled/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/dsl/testing/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/model/api/dependencies/runtimeClasspath.txt # modulecheck-parsing/gradle/model/impl-typesafe/dependencies/runtimeClasspath.txt # modulecheck-parsing/groovy-antlr/dependencies/runtimeClasspath.txt # modulecheck-parsing/java/dependencies/runtimeClasspath.txt # modulecheck-parsing/psi/dependencies/runtimeClasspath.txt # modulecheck-parsing/source/api/dependencies/runtimeClasspath.txt # modulecheck-parsing/wiring/dependencies/runtimeClasspath.txt # modulecheck-project/api/build.gradle.kts # modulecheck-project/api/dependencies/runtimeClasspath.txt # modulecheck-project/impl/dependencies/runtimeClasspath.txt # modulecheck-reporting/checkstyle/dependencies/runtimeClasspath.txt # modulecheck-reporting/console/dependencies/runtimeClasspath.txt # modulecheck-reporting/graphviz/dependencies/runtimeClasspath.txt # modulecheck-reporting/sarif/dependencies/runtimeClasspath.txt # modulecheck-rule/api/dependencies/runtimeClasspath.txt # modulecheck-rule/impl-factory/dependencies/runtimeClasspath.txt # modulecheck-rule/impl/dependencies/runtimeClasspath.txt # modulecheck-rule/impl/src/main/kotlin/modulecheck/rule/impl/OverShotDependencyRule.kt # modulecheck-rule/impl/src/main/kotlin/modulecheck/rule/impl/UnusedDependencyRule.kt # modulecheck-rule/testing/dependencies/runtimeClasspath.txt # modulecheck-runtime/api/dependencies/runtimeClasspath.txt # modulecheck-utils/cache/dependencies/runtimeClasspath.txt # modulecheck-utils/coroutines/dependencies/runtimeClasspath.txt # modulecheck-utils/lazy/dependencies/runtimeClasspath.txt
RBusarow
added a commit
that referenced
this pull request
Jun 2, 2022
* main: parse the declarations of named companion objects and their members fixes #705 use graphviz-java for dot graph generation Update dependency com.autonomousapps.dependency-analysis to v1.4.0 Update dependency com.osacky.doctor to v0.8.1 update website actions to use node 18.x treat annotation processor dependencies the same as runtime dependencies for `McProject.uses()` and overshot behavior (#701) # Conflicts: # modulecheck-gradle/plugin/src/main/kotlin/modulecheck/gradle/internal/GradleProjectProvider.kt # modulecheck-project/testing/build.gradle.kts # modulecheck-project/testing/src/main/kotlin/modulecheck/project/test/McProjectBuilder.kt # modulecheck-project/testing/src/main/kotlin/modulecheck/project/test/ProjectCollector.kt
RBusarow
added a commit
that referenced
this pull request
Jun 2, 2022
* main: parse the declarations of named companion objects and their members fixes #705 use graphviz-java for dot graph generation Update dependency com.autonomousapps.dependency-analysis to v1.4.0 Update dependency com.osacky.doctor to v0.8.1 update website actions to use node 18.x treat annotation processor dependencies the same as runtime dependencies for `McProject.uses()` and overshot behavior (#701) # Conflicts: # modulecheck-gradle/plugin/src/main/kotlin/modulecheck/gradle/internal/GradleProjectProvider.kt # modulecheck-project/testing/build.gradle.kts # modulecheck-project/testing/src/main/kotlin/modulecheck/project/test/McProjectBuilder.kt # modulecheck-project/testing/src/main/kotlin/modulecheck/project/test/ProjectCollector.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #700