don't generate BuildConfig if it's ignored in Android settings #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
reviewed
Mar 21, 2022
| } | ||
|
|
||
| @Test | ||
| fun `buildConfig task should not be required when disabled in android library module`() { |
Contributor
There was a problem hiding this comment.
What if it is disabled via gradle.properties. Does this handle that automatically?
Member
Author
There was a problem hiding this comment.
gradle.properties, -Pandroid.defaults.buildfeatures.buildconfig=false, and the dsl are all functionally the same. The dsl extensions all just delegate to project.properties.
Contributor
There was a problem hiding this comment.
Didn't know. That's very neat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453