Implementation - Settlement API, issue, cancel, send/ resend notification, delete, edit methods #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added in invoice file and new api i.e. settlement api
…ssue, edit method added in invoice file and new api i.e. settlement api
Contributor
|
@varunajmera0 Thanks for the Pull Request! We're getting this reviewed internally. 🔜 |
…point and test file is created for settlement and test function is done in test invoice file
…point and test file is created for settlement and test function is done in test invoice file
…ncel, delete and issue endpoint and test file is created for settlement and test function is done in test invoice file
jitendra-1217
approved these changes
Mar 11, 2019
| - Create payment link | ||
|
|
||
| ```py | ||
| DATA = {"customer": { "name": "Varun Test", |
Contributor
There was a problem hiding this comment.
Need to fix formatting and sample data in all these snippets.
| invoice_id : Id for delete the invoice | ||
| data : Dictionary having keys using which invoice have to be updated | ||
| Returns: | ||
| { |
Contributor
There was a problem hiding this comment.
Too verbose comment in code, can just say returns json for invoice entity and link to existing docs containing this sample.
Contributor
|
Merging this now. Thanks a lot @varunajmera0 👍 |
Contributor
|
Thanks @varunajmera0 💯 |
Contributor
Author
|
thanks, @jitendra-1217 @amitmahbubani @captn3m0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my implementation:-
I updated the invoice file methods like -
You can use these methods on payment link.
A new Settlement API is done.