Wrapper for OAuth URLs #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=============================================
+ Coverage 73.67% 83.77% +10.10%
- Complexity 240 306 +66
=============================================
Files 53 58 +5
Lines 528 709 +181
Branches 20 31 +11
=============================================
+ Hits 389 594 +205
+ Misses 120 91 -29
- Partials 19 24 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shwatang
commented
Feb 5, 2024
KUNAL13
reviewed
Feb 6, 2024
| String scopesArray = scopes.length > 0 ? | ||
| "&scope[]=" + String.join("&scope[]=", scopes) : ""; | ||
|
|
||
| String AuthorizeUrl = "https://" |
There was a problem hiding this comment.
use url builder? it will take care of encoding wherever necessary
KUNAL13
reviewed
Feb 9, 2024
KUNAL13
approved these changes
Feb 9, 2024
KUNAL13
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.