Skip to content

chore: docs fixes #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravisuhag merged 4 commits into from
Aug 9, 2023
Merged

chore: docs fixes #165

ravisuhag merged 4 commits into from
Aug 9, 2023

Conversation

@punit-kulal
Copy link
Contributor

@punit-kulal punit-kulal commented Jul 24, 2023 •
edited
Loading

  • Fixed quickstart documentation via cli. (Earlier commands failed since http:// was prefixed for grpc call)
  • Improved config defaults for easier quickstart
  • Updated gitignore to ignore examples and debug files

@punit-kulal punit-kulal requested a review from ravisuhag July 24, 2023 12:57
@punit-kulal punit-kulal marked this pull request as draft July 24, 2023 13:06
@ravisuhag ravisuhag changed the title Doc fixes chore: docs fixes Aug 9, 2023
@ravisuhag
Copy link
Member

ravisuhag commented Aug 9, 2023

@punit-kulal can we merge this?

@punit-kulal punit-kulal marked this pull request as ready for review August 9, 2023 08:54
@punit-kulal
Copy link
Contributor Author

punit-kulal commented Aug 9, 2023

Yes, have opened it for review

@ravisuhag ravisuhag merged commit d549cc7 into main Aug 9, 2023
@ravisuhag ravisuhag deleted the doc-fixes branch August 9, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@punit-kulal @ravisuhag