Skip to content

feat(cli): enhance namespace command experience #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravisuhag merged 12 commits into from
Sep 6, 2022
Merged

feat(cli): enhance namespace command experience #144

ravisuhag merged 12 commits into from
Sep 6, 2022

Conversation

@ravisuhag
Copy link
Member

@ravisuhag ravisuhag commented Sep 1, 2022 •
edited
Loading

  • Ask for confirmation in delete namespace command
  • Prompt user to provide inputs in namespace create
  • Better handle GRPC errors
  • Improve CLI messages

@ravisuhag ravisuhag requested review from h4rikris and mabdh September 3, 2022 03:29
@ravisuhag ravisuhag marked this pull request as ready for review September 3, 2022 07:38
@ravisuhag ravisuhag changed the title style(cli): update namespace cmd messages feat(cli): enhance namespace command UX Sep 3, 2022
@ravisuhag ravisuhag changed the title feat(cli): enhance namespace command UX feat(cli): enhance namespace command experience Sep 3, 2022
mabdh
mabdh reviewed Sep 6, 2022
View reviewed changes
@ravisuhag @mabdh
chore: update cmd/namespace.go
45f9012 
Co-authored-by: Abduh <mabdh@users.noreply.github.com>
@ravisuhag ravisuhag merged commit 47c93cb into main Sep 6, 2022
@ravisuhag ravisuhag deleted the cmd-prints branch September 6, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabdh mabdh mabdh left review comments

@h4rikris h4rikris Awaiting requested review from h4rikris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ravisuhag @mabdh