Skip to content

feat(bigquery): add support to capture schema of nested fields #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsushmith merged 4 commits into from
Mar 3, 2023
Merged

feat(bigquery): add support to capture schema of nested fields #476

bsushmith merged 4 commits into from
Mar 3, 2023

Conversation

@anjali9791
Copy link
Contributor

@anjali9791 anjali9791 commented Mar 2, 2023 •
edited by sudo-suhas
Loading

Closes: #462

edit: change refer to closes

@anjali9791
Copy link
Contributor Author

anjali9791 commented Mar 2, 2023

The http_extractor_test.go failing in plugins-test here is passing on my local. Here is a screenshot for the same.
Screenshot 2023-03-02 at 10 06 33 PM

@sudo-suhas
Copy link
Contributor

sudo-suhas commented Mar 3, 2023

Could you change the expectedErr for that test to Error:Field validation for 'url' failed on the 'required' tag? The failure is because of the different ordering between content_type and accept.

sudo-suhas
sudo-suhas reviewed Mar 3, 2023
View reviewed changes
@StewartJingga StewartJingga changed the title feat(bigqeury): add support to capture schema of nested fields feat(bigquery): add support to capture schema of nested fields Mar 3, 2023
@bsushmith bsushmith merged commit 905cc68 into raystack:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsushmith bsushmith bsushmith approved these changes

@sudo-suhas sudo-suhas sudo-suhas approved these changes

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

capture nested fields in RECORD type col in bigquery extractor

4 participants

@anjali9791 @sudo-suhas @bsushmith @anjaliagg9791