Skip to content

fix(admin): update sort key name case as api response#1443

Merged
rsbh merged 5 commits intomainfrom
fix_admin_sort_key_name
Mar 10, 2026
Merged

fix(admin): update sort key name case as api response#1443
rsbh merged 5 commits intomainfrom
fix_admin_sort_key_name

Conversation

@rsbh
Copy link
Member

@rsbh rsbh commented Mar 9, 2026

Summary

  • Fix sort key name casing to match API response
  • Add missing imports in organization projects view
  • Update @raystack/apsara to 0.56.6

Test Plan

  • Manual testing completed
  • Build and type checking passes

@vercel
Copy link

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 10, 2026 4:51am

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Refactor

    • Standardized internal field naming and import formatting across multiple admin list and detail views to improve consistency.
    • Default sort behavior remains by creation date (descending); user-facing ordering unchanged.
  • Chores

    • Bumped a transitive dependency to a newer patch release.

Walkthrough

Standardizes default sort field names from snake_case to camelCase across several admin list/detail views (e.g., created_atcreatedAt). Members view also reorganizes imports and renames org_joined_atorgJoinedAt. Dependency @raystack/apsara bumped in two package.json files. No exported/public APIs changed.

Changes

Cohort / File(s) Summary
Sort field standardization
web/sdk/admin/views/organizations/details/apis/index.tsx, web/sdk/admin/views/organizations/details/invoices/index.tsx, web/sdk/admin/views/organizations/details/tokens/index.tsx, web/sdk/admin/views/organizations/list/index.tsx, web/sdk/admin/views/users/list/list.tsx
Changed DEFAULT_SORT name from snake_case (created_at) to camelCase (createdAt) while keeping order: 'desc'. Relies on existing transform/mapping for backend field names.
Members view reorganization
web/sdk/admin/views/organizations/details/members/index.tsx
Reordered and normalized imports (single-quote style); renamed sort key from org_joined_at to orgJoinedAt and updated TRANSFORM_OPTIONS mapping accordingly.
Projects view import tweaks
web/sdk/admin/views/organizations/details/projects/index.tsx
Adjusted import formatting and quote styles (consolidated useInfiniteQuery import); changed DEFAULT_SORT from created_at to createdAt.
Dependency bumps
web/apps/admin/package.json, web/sdk/package.json
Updated @raystack/apsara version from 0.56.50.56.6 in affected package.json files.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • paanSinghCoder
  • rohilsurana

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Mar 9, 2026

Pull Request Test Coverage Report for Build 22887660489

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.425%

Totals Coverage Status
Change from base Build 22839634240: 0.0%
Covered Lines: 13968
Relevant Lines: 34553

💛 - Coveralls

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 99616745-3dca-4e2c-b7b5-702a81a8b3c6

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6d0cd and dd865ae.

📒 Files selected for processing (7)
  • web/sdk/admin/views/organizations/details/apis/index.tsx
  • web/sdk/admin/views/organizations/details/invoices/index.tsx
  • web/sdk/admin/views/organizations/details/members/index.tsx
  • web/sdk/admin/views/organizations/details/projects/index.tsx
  • web/sdk/admin/views/organizations/details/tokens/index.tsx
  • web/sdk/admin/views/organizations/list/index.tsx
  • web/sdk/admin/views/users/list/list.tsx

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
web/sdk/package.json (1)

71-71: Verify the SDK’s peer floor matches the new Apsara minimum.

This bump implies 0.56.6 may be part of the runtime fix, but the package still allows @raystack/apsara >=0.30.0 on Line 123. If consumers install an older peer, they can miss the behavior this PR depends on. Please confirm the actual minimum supported version and tighten the peer range if 0.56.6 is now required.

Proposed manifest change
  "peerDependencies": {
-   "@raystack/apsara": ">=0.30.0",
+   "@raystack/apsara": ">=0.56.6",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d80097e-f6fa-4dfe-95ec-8d699d447e78

📥 Commits

Reviewing files that changed from the base of the PR and between e22e38b and 01120f4.

⛔ Files ignored due to path filters (1)
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • web/apps/admin/package.json
  • web/sdk/package.json

@rsbh rsbh merged commit 789e0b7 into main Mar 10, 2026
8 checks passed
@rsbh rsbh deleted the fix_admin_sort_key_name branch March 10, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants