Skip to content

fix (organisations): ui shift due to missing min-height#1441

Merged
paanSinghCoder merged 3 commits intomainfrom
fix/navbar-search-ui-shift
Mar 9, 2026
Merged

fix (organisations): ui shift due to missing min-height#1441
paanSinghCoder merged 3 commits intomainfrom
fix/navbar-search-ui-shift

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Mar 6, 2026

Summary

  • improvement: replace InputField with Search component for the search bar. Also, enable clear button.
  • fix: add min-height: var(--rs-space-11); 48px to the navbar to avoid UI shift when Search is toggled on page change.

After the fix:

Screen.Recording.2026-03-06.at.11.55.37.AM.mov

Test Plan

  • Manual testing completed
  • Build and type checking passes

@paanSinghCoder paanSinghCoder self-assigned this Mar 6, 2026
@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 9, 2026 3:50am

@paanSinghCoder paanSinghCoder added the bug Something isn't working label Mar 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9aaa5c21-ef1c-429e-9250-7d282c6d678a

📥 Commits

Reviewing files that changed from the base of the PR and between 06bf3a7 and 7c6db6e.

📒 Files selected for processing (2)
  • web/sdk/admin/views/organizations/details/layout/layout.module.css
  • web/sdk/admin/views/organizations/details/layout/navbar.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Increased navbar height in admin organization details for improved spacing
    • Enhanced search input with a dedicated clear button for easier query management

Walkthrough

Updated the organization details navbar to replace the InputField component with a Search component, adding clear functionality and size adjustments. Concurrently adjusted the navbar's minimum height styling in the accompanying CSS module.

Changes

Cohort / File(s) Summary
Navbar layout styling and search component updates
web/sdk/admin/views/organizations/details/layout/layout.module.css, web/sdk/admin/views/organizations/details/layout/navbar.tsx
Replaced InputField with Search component in navbar, adding onClear, size="small", and showClearButton props. Updated import statements accordingly. Increased .navbar minimum height via CSS variable (--rs-space-11).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • rohilsurana

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Mar 6, 2026

Pull Request Test Coverage Report for Build 22837540032

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.425%

Totals Coverage Status
Change from base Build 22760931203: 0.0%
Covered Lines: 13968
Relevant Lines: 34553

💛 - Coveralls

@paanSinghCoder paanSinghCoder merged commit 92cc59b into main Mar 9, 2026
8 checks passed
@paanSinghCoder paanSinghCoder deleted the fix/navbar-search-ui-shift branch March 9, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants